chore: release v0.0.5 #261
Conversation
feat: add check for selector visibility, revert domcontentloaded to networkidle state
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request involves modifications to the Changes
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
amhsirak
added
the
Type: New Release
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docker-compose.yml (2)
Line range hint
1-85: Version mismatch between PR and container imagesThe PR is for release v0.0.5, but the compose file references:
- Backend image: v0.0.7
- Frontend image: v0.0.3
This version mismatch needs clarification:
- Are these the correct image versions for this release?
- Should the versions be updated to match v0.0.5?
🧰 Tools
🪛 yamllint (1.35.1)
[error] 86-86: no new line character at the end of file
(new-line-at-end-of-file)
86-86: Add newline at end of fileThe file is missing a newline character at the end, which is a POSIX requirement.
Apply this fix:
redis_data: +🧰 Tools
🪛 yamllint (1.35.1)
[error] 86-86: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docker-compose.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
docker-compose.yml
[error] 86-86: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
docker-compose.yml (1)
Line range hint 1-85: Verify the architectural changes from development to production setup
The removal of volume mounts (./server:/app/server, ./maxun-core:/app/maxun-core for backend and ./:/app, /app/node_modules for frontend) indicates a shift from a development setup with hot-reloading to a production-like environment using built images. This aligns with release practices but requires verification.
Run the following to verify the image versions and their contents:
✅ Verification successful
Architectural changes are appropriate for a production release
The removal of volume mounts is correct for a production setup as:
- The Dockerfiles show proper build processes for both frontend and backend
- Backend image (v0.0.7) includes all necessary production dependencies and Playwright setup
- Frontend image (v0.0.3) contains the built application code
- The docker-compose.yml correctly maintains essential volumes for data persistence (postgres_data, minio_data)
- Development-specific volume mounts are appropriately removed as they're not needed in production
The changes align with standard practices for transitioning from development to production Docker configurations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify image versions and their contents
# Check if the images exist and their creation dates
docker pull getmaxun/maxun-backend:v0.0.7
docker pull getmaxun/maxun-frontend:v0.0.3
docker inspect getmaxun/maxun-backend:v0.0.7 | jq '.[].Created'
docker inspect getmaxun/maxun-frontend:v0.0.3 | jq '.[].Created'
Length of output: 609
Script:
#!/bin/bash
# Let's verify the architectural changes by checking for Dockerfile contents
# and any related configuration files that might show the production setup
# Check for Dockerfiles
fd Dockerfile
# Look for any deployment or environment configuration files
fd -e yaml -e yml -e env
# Check for documentation about deployment
fd README.md
# Let's also look for any configuration management in package.json files
fd package.json
# Examine the content of found files for deployment-related configurations
cat $(fd -e md) 2>/dev/null || true
cat $(fd package.json) 2>/dev/null || true
cat $(fd Dockerfile) 2>/dev/null || true
Length of output: 16697
🧰 Tools
🪛 yamllint (1.35.1)
[error] 86-86: no new line character at the end of file
(new-line-at-end-of-file)
fix: scrapeList empty output preview
feat: browser improvements
feat: selection revamp
Summary by CodeRabbit