This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat: Update unified API page #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
s1gr1d
reviewed
Jun 19, 2024
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
s1gr1d
approved these changes
Jun 20, 2024
sl0thentr0py
suggested changes
Jun 25, 2024
| Each thread local SHOULD hold a reference to the current scope & isolation scope that is active for the current thread. | ||
| Newly spawned threads SHOULD inherit the reference to the isolation scope from the parent thread, and SHOULD create a new scope that is a child of the parent current scope, and make this the current scope for the child thread. | ||
|
|
||
| The isolation scope MAY be forked (instead of using the same reference) for a new thread if the SDK identifies that the new thread is a new logical operation that should not share data with the parent thread. |
There was a problem hiding this comment.
can we have a small clarification that the current scope is mainly for span tracking purposes while the isolation scope is for tracking a unit of logical isolation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the current "Unified API" page to "Hub based API", and updates the unified API page to be based around the new scope-only world.
There is for sure some stuff to change here yet, esp. around the async threads stuff - feel free to propose changes etc!