-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): add python onboarding sidebar #80871
base: master
Are you sure you want to change the base?
Conversation
Bundle ReportChanges will increase total bundle size by 22.17kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80871 +/- ##
==========================================
- Coverage 78.41% 78.40% -0.01%
==========================================
Files 7209 7212 +3
Lines 319622 319690 +68
Branches 44006 44013 +7
==========================================
+ Hits 250642 250664 +22
- Misses 62594 62640 +46
Partials 6386 6386 |
<div> | ||
<LinkButton | ||
size="sm" | ||
href="" // TODO: docs link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't sure what link to use here, i don't think we have a general feature flag page in docs yet
disabled={setupMode() === 'other'} | ||
/> | ||
), | ||
link: <ExternalLink href="" />, // TODO: link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't sure whether to use the OpenFeature site here (https://openfeature.dev/) or the sentry specific docs (https://docs.sentry.io/platforms/python/integrations/openfeature/)
<div> | ||
<LinkButton | ||
size="sm" | ||
href="" // TODO: docs link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, not sure what docs to use
Wow great work Michelle! |
what does this pr do?
flow walkthrough
The sidebar is triggered by the "set up integration" button on the feature flags table on issue details.
It opens a flyout sidebar, which explains onboarding instructions for how to set up feature flag integrations. Depending on whether OpenFeature is selected (which allows for an additional dropdown to pick another provider) or another SDK, the instructions will vary.
LD:
OpenFeature with LD:
signing secret
At the bottom of the sidebar is a spot to post a signing secret, which is what we use to verify the integration. This posts to the
/signing-secret/
endpoint:sentry/src/sentry/api/urls.py
Lines 2072 to 2076 in 9dfbc5a
Screen.Recording.2024-11-15.at.3.10.45.PM.mov
when the token is saved, a success banner appears:
video demos
triggering from issue details:
of.mov
example of what it would look like if OpenFeature had multiple options:
Screen.Recording.2024-11-15.at.2.47.54.PM.mov
todo (this PR):
todo (followups)
event.contexts.flags
is not undefined, we should hide the first half of the onboarding as specified in the designs