Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grouping): Differentiate fingerprint and enhancements class names #80872

Open
wants to merge 5 commits into
base: kmclb-store-hashing-metadata
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

Both fingerprinting rules and stacktrace rules ("enhancements") use classes called Rule and Match, and without spending time figuring out the context, it's hard to tell which of them one is dealing with. This therefore changes the names all four classes (along with the enhancements Action class, just to keep things standardized) to include Fingerprint or Enhancement as appropriate. No behavior changes, just a lot of find and replace.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/grouping/enhancer/matchers.py 77.77% 2 Missing ⚠️
src/sentry/grouping/enhancer/rules.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           kmclb-store-hashing-metadata   #80872      +/-   ##
================================================================
- Coverage                         78.42%   78.42%   -0.01%     
================================================================
  Files                              7211     7211              
  Lines                            319795   319795              
  Branches                          44027    44027              
================================================================
- Hits                             250800   250797       -3     
- Misses                            62604    62606       +2     
- Partials                           6391     6392       +1     

@lobsterkatie lobsterkatie marked this pull request as ready for review November 15, 2024 23:52
@lobsterkatie lobsterkatie requested a review from a team as a code owner November 15, 2024 23:52
Copy link
Member

@snigdhas snigdhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants