Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSH support for age #1692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SSH support for age #1692

wants to merge 2 commits into from

Conversation

haoqixu
Copy link

@haoqixu haoqixu commented Dec 1, 2024

Continues #1134.

@haoqixu
Copy link
Author

haoqixu commented Dec 1, 2024

This PR rebases #1134 and includes _FILE in the environment variable according to the suggestion in #1134 (comment), but uses SopsAgeSshPrivateKeyFileEnv instead of SopsAgeSshPrivateKeyEnvFile to stay aligned with SopsAgeKeyFileEnv.

@haoqixu haoqixu marked this pull request as draft December 1, 2024 21:48
@haoqixu haoqixu marked this pull request as ready for review December 1, 2024 21:57
@haoqixu haoqixu mentioned this pull request Dec 1, 2024
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2024
View reviewed changes
age/tui.go
if err != nil {
return nil, err
}
defer in.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
age/tui.go
if err != nil {
return nil, err
}
defer out.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
age/tui.go
if err != nil {
return nil, err
}
defer tty.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
This was referenced Dec 3, 2024
Open
Open
mstrangfeld and others added 2 commits December 16, 2024 12:13
@mstrangfeld @haoqixu
feat: add ssh support for age
9bd489a 
Signed-off-by: Marvin Strangfeld <marvin@strangfeld.io>
@haoqixu
Rename SopsAgeSshPrivateKeyEnv to SopsAgeSshPrivateKeyFileEnv
b325a74 
Signed-off-by: haoqixu <hq.xu0o0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoqixu @mstrangfeld