Uniformizing error message and error message formatting #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After launching GTG from flatpak I got an ill formatted error (showing `%s` instead of the proper values). It's due to a `raise ValueError` in `GTG/core/config.py`. After looking at that I started just fixing and uniformizing the error message formatting across GTG. Here's what's in the PR : * uniformizing error message formating : * using the same string formatting mechanism * raise `NotImplementedError` not `NotImplemented` which isn't an exception ``` >>> raise NotImplemented Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: exceptions must derive from BaseException ``` * do not explicitly reraise current error in an `except:` block, juste use bare `raise` statement * raise error objects, not classes
jaesivsm
force-pushed
the
fix/uniformizing-raising
branch
from
4fb85e0 to
d04ad6c
Compare
Neui
approved these changes
May 29, 2022
|
Bonjour François, please rebase to current |
nekohayo
added
the
maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After launching GTG from flatpak I got an ill formatted error (showing
%sinstead of the proper values). It's due to araise ValueErrorinGTG/core/config.py. After looking at that I started just fixing and uniformizing the error message formatting across GTG. Here's what's in the PR :NotImplementedErrornotNotImplementedwhich isn't an exceptionexcept:block, juste use bareraisestatementEdit: encountered same error than #877