Expose TextureViewArray, SamplerArray and associated extensions to the C API #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my bad, left the define WGPU_TARGET_WINDOWS 1 in examples/triangle/main.c. Should be fixed now |
rajveermalviya
previously requested changes
Jun 20, 2023
|
Ping from triage |
|
I have rebased this branch & and added a new example |
almarklein
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the wgpu-native bindings from C# and realised that one of the features I required was missing, namely texture view arrays/sampler arrays as specified here (https://wgpu.rs/doc/wgpu/enum.BindingResource.html), so I implemented the features and created this pull request. It also exposes TEXTURE_BINDING_ARRAY and SAMPLED_TEXTURE_AND_STORAGE_BUFFER_ARRAY_NON_UNIFORM_INDEXING as features to the C API via wgpu.h
I'm not a rust developer and have never written anything in rust before. This is also my first pull request so any feedback is appreciated!