Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgen: Only bind WGPU.* and wgpu.*. #361

Merged
merged 1 commit into from
Jan 29, 2024
Merged

bindgen: Only bind WGPU.* and wgpu.*. #361

merged 1 commit into from
Jan 29, 2024

Conversation

waywardmonkeys
Copy link
Contributor

The bindings only need to include things from the WGPU API, not stuff from the headers that they happen to include from the compiler and libc.

@waywardmonkeys
bindgen: Only bind WGPU.* and wgpu.*.
d5eef85 
The bindings only need to include things from the WGPU API,
not stuff from the headers that they happen to include from
the compiler and libc.
rajveermalviya
rajveermalviya approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I checked the generated bindings.rs and it's much smaller, also bindgen runs a little bit faster.

@rajveermalviya rajveermalviya merged commit 9f863b6 into gfx-rs:trunk Jan 29, 2024
16 checks passed
@waywardmonkeys waywardmonkeys deleted the only-generate-wgpu-bindings branch January 29, 2024 11:53
@waywardmonkeys waywardmonkeys mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajveermalviya rajveermalviya rajveermalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @rajveermalviya