Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose missing native features up to v0.19.4 #384

Merged
merged 2 commits into from
May 7, 2024

Conversation

davnotdev
Copy link
Contributor

#190 This exposes WGPU native features up to v0.19.4. However, I'm not sure what values should be attributed to each feature. From what I've observed, the "correct" ordering of features doesn't matter since they change with each WGPU version anyway.

Copy link
Collaborator

@rajveermalviya rajveermalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @davnotdev

Unfortunately we can't expose some features directly because they also need to be coupled with API changes. So for this PR we can just remove such features for now, and make separate PRs for the ones that require API changes.

Here's a list I made for the features that can't exposed directly:

TIMESTAMP_QUERY_INSIDE_PASSES

Need to expose functions RenderPassEncoder::write_timestamp & ComputePassEncoder::write_timestamp.

ADDRESS_MODE_CLAMP_TO_ZERO

Need to expose struct member SamplerDescriptor.border_color.

ADDRESS_MODE_CLAMP_TO_BORDER

Need to expose enum AddressMode::ClampToBorder

POLYGON_MODE_LINE & POLYGON_MODE_POINT

Need to expose struct member PrimitiveState.polygon_mode.

CONSERVATIVE_RASTERIZATION

Need to expose struct member PrimitiveState.conservative.

CLEAR_TEXTURE

Need to expose function CommandEncoder::clear_texture.

SPIRV_SHADER_PASSTHROUGH

Need to expose function Device::create_shader_module_spirv

MULTIVIEW

Need to expose struct member RenderPipelineDescriptor.multiview

@davnotdev
Copy link
Contributor Author

Sounds good! Thanks for listing them out too, that helps immensely.

@rajveermalviya
Copy link
Collaborator

Thanks!

@rajveermalviya rajveermalviya merged commit 85563e5 into gfx-rs:trunk May 7, 2024
16 checks passed
@Speak2Erase
Copy link

I'd like to contribute to the project by re-exposing some of these features- how would I do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants