Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move renderpass end validation in creation to match the spec #6735

Open
sagudev opened this issue Dec 14, 2024 · 0 comments
Open

[core] Move renderpass end validation in creation to match the spec #6735

sagudev opened this issue Dec 14, 2024 · 0 comments
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@sagudev
Copy link
Contributor

sagudev commented Dec 14, 2024

Currently we do excessive validation when ending pass

check_multiview(view)?;
that should be moved into
fn fill_arc_desc(
to match the spec:
https://gpuweb.github.io/gpuweb/#ref-for-abstract-opdef-gpurenderpassdescriptor-valid-usage
https://gpuweb.github.io/gpuweb/#abstract-opdef-gpurenderpassdescriptor-valid-usage
https://gpuweb.github.io/gpuweb/#abstract-opdef-gpurenderpassdepthstencilattachment-gpurenderpassdepthstencilattachment-valid-usage

related: #6716

@cwfitzgerald cwfitzgerald added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants