[core] Support optional ops in PassChannel #6716
Merged
+91
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
changed the title
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 13, 2024
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 13, 2024
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "bencher": false, "wpt_args": "_webgpu"}]}
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
|
CTS: |
sagudev
commented
Dec 14, 2024
Comment on lines
-938
to
-947
| view.same_device(device)?; | ||
| check_multiview(view)?; | ||
| add_view(view, AttachmentErrorLocation::Depth)?; | ||
|
|
||
| let ds_aspects = view.desc.aspects(); | ||
| if ds_aspects.contains(hal::FormatAspects::COLOR) { | ||
| return Err(RenderPassErrorInner::InvalidDepthStencilAttachmentFormat( | ||
| view.desc.format, | ||
| )); | ||
| } |
There was a problem hiding this comment.
This checks are now part of creation, in a followup I will move even more checks, see #6735 for more info.
sagudev
commented
Dec 14, 2024
Comment on lines
+1478
to
+1487
| depth: if format.has_depth_aspect() { | ||
| depth_stencil_attachment.depth.resolve()? | ||
| } else { | ||
| Default::default() | ||
| }, | ||
| stencil: if format.has_stencil_aspect() { | ||
| depth_stencil_attachment.stencil.resolve()? | ||
| } else { | ||
| Default::default() | ||
| }, |
There was a problem hiding this comment.
This is rather unfortunate, but I didn't want to touch RenderPassInfo::start to much (at least not in this PR).
There was a problem hiding this comment.
Yeah, it would be nice to make some rusty types for these after validation.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #6700
Description
When attachment is read only, ops must not be provided (else validation error should be raised). To support this
PassChannelis generic over L and S, so we can use same struct forLoadOporOption<LoadOp>. Now core users will passPassChannel<V, Option<LoadOp>, Option<StoreOp>>that will be be resolved toPassChannel<V, LoadOp, StoreOp>, which is used same as before internally. While resolving we also do validation.Changes needed in servo: sagudev/servo@4aa142c.
Testing
CTS run in servo: #6716 (comment) and existing test.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.