-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DXR in wgpu-hal & naga. #6777
base: trunk
Are you sure you want to change the base?
Conversation
…tracing # Conflicts: # naga/src/back/hlsl/writer.rs # wgpu-hal/src/dx12/device.rs
…RUCTURE` as we don't yet support enhanced barriers for acceleration structures
I ran the tests for this and it doesn't appear to be working properly? (6800xt/RDNA2 has RT support, I ran
edit: This is probably #6728, I'll try reverting that and see if it works. edit2: Nope, reverted that and it's now saying edit3: Looks like you need to set the |
This should now default to static-dxc after #6730 |
Since that's on a AMD GPU, that means that this probably does provide an alternative (and may also point to the issue being a wgpu bug vs a AMD bug) Edit: I'm not sure what GPU generations were being affected though. |
Same, my 7800xtx passes all tests |
Connections
Might provide alternatives for #6727?
Description
This adds support for DXR in wgpu-hal. Also removes an unnecessary feature requirement from ray_cube_compute as this was preventing it from running on DX12. Also adds support for HLSL raytracing because naga didn't have that either.
Testing
this only extends feature support to dx12 so all previous rt tests work.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.