-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json
: support integer minimum, maximum, exclusiveMinimum, exclusiveMaximum
#7797
Merged
Merged
Changes from 27 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
057bbdc
json: support minimum for positive integer values
ochafik d69ccb0
json: fix min 0
ochafik c37c484
json: min + max integer constraints
ochafik af63f4f
json: handle negative min / max integer bounds
ochafik a381deb
json: fix missing paren min/max bug
ochafik f8db478
json: proper paren fix
ochafik 5a86c6f
json: integration test for schemas
ochafik 431edb8
json: fix bounds tests
ochafik b6b6a6c
Update json-schema-to-grammar.cpp
ochafik a786c03
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik 931b543
json: fix negative max
ochafik 4c1c293
json: fix negative min (w/ more than 1 digit)
ochafik ac2a8f8
Update test-grammar-integration.cpp
ochafik 3549702
json: nit: move string rules together
ochafik e933680
json: port min/max integer support to Python & JS
ochafik a0f1904
nit: move + rename _build_min_max_int
ochafik dcc27d1
fix min in [1, 9]
ochafik d1f6791
Update test-grammar-integration.cpp
ochafik cad377d
add C++11-compatible replacement for std::string_view
ochafik d6483a9
add min/max constrained int field to pydantic json schema example
ochafik f03e9b9
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik 6fa7364
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik 948e55e
fix merge
ochafik 670d5a6
json: add integration tests for min/max bounds
ochafik 9fb8a75
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik d7d957d
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik 3a80d1e
reshuffle/merge min/max integ test cases
ochafik 09a9b75
nits / cleanups
ochafik 48f417d
Merge remote-tracking branch 'origin/master' into json-bounds2
ochafik 36bf003
defensive code against string out of bounds (apparently different beh…
ochafik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're changing
min_items
toconst
, is it worth addingconst
tomax_items
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped unintended change, thanks!