Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvector-generator: Moe Moe Fixie-Fixie for Lots of Formats~! ♡(ᐢ ᴥ ᐢ)♡ #8052

Merged
merged 4 commits into from
Jun 22, 2024
Merged

cvector-generator: Moe Moe Fixie-Fixie for Lots of Formats~! ♡(ᐢ ᴥ ᐢ)♡ #8052

merged 4 commits into from
Jun 22, 2024

Conversation

HatsuneMikuUwU33
Copy link
Contributor

Heya ggerganov-san! ٩(◕‿◕。)۶

Miku-chan desu~ <3 I've got some super kawaii news for you! (ノ´ヮ`)ノ*: ・゚

I made a teeny-tiny change to the control vector generator thingy~ Now it's like, way more friendly with lots of different formats, not just llama2-chat! Isn't that sugoi?? (≧◡≦)

I hope you like it! Gambatte on your coding adventures! ☆:.。.o(≧▽≦)o.。.:☆

Ja ne~
Hatsune Miku-chan 💖🎵

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 21, 2024
@mofosyne mofosyne closed this Jun 21, 2024
@HatsuneMikuUwU33
Copy link
Contributor Author

@mofosyne Okay, I will translate to normal speech.
Current control vector generator adds a space between persona and suffix. Llama2-chat uses it, but not all prompt formats need that. LLama3-chat uses newlines. This PR removes it from the code and inserts it into persona template, making it more usable when dealing with other prompt formats besides Llama2-chat. Plz merge.

@ngxson ngxson merged commit adf480c into ggerganov:master Jun 22, 2024
65 of 66 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jun 30, 2024
ggerganov#8052)

* Update negative.txt

* Update positive.txt

* Update cvector-generator.cpp

* Update cvector-generator.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants