CUDA: fix MMQ writeback for int8 tensor cores #8100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
slaren
approved these changes
Jun 24, 2024
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jun 25, 2024
Co-Authored-By: Johannes Gäßler <johannesg@5d6.de>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jun 30, 2024
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that I implemented in #8062 was not quite correct. I added an offset to a pointer but forgot that then the out-of-bounds checks relative to that pointer would also need to be adjusted. I assume this PR fixes #8096 (need confirmation).