Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vulkan : cmake integration #8119
vulkan : cmake integration #8119
Changes from 37 commits
4eadfb1
c46a789
36b081a
29ba5a8
1b4759f
cb3ec88
37bcad7
b1a70fc
dd198ce
491a967
99c3027
8859546
c61cd05
2318cad
a1495e7
6571046
d053004
d0d825f
eec17a6
8590508
ac9a065
4eab311
9bca872
422bfb3
22323d5
2f5a0e8
a85b5d8
019e4a3
3a554ae
dafcaf1
4226103
613a3c6
f638ade
02e65ad
6b5c5af
50da329
f47829a
9501f66
88fd99b
24fd7d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is needed - an example with a specific flag that is not exported would help. It's OK to merge as it is though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggerganov I will take a closer look at this. The flags which should be exported should be all interface defines (public interface only) on the ggml/llama libraries. I will follow up with a new pull request.