Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise resource names #16

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Conversation

seia-soto
Copy link
Member

This PR adds the normalisation of resource names. It extracts redirects.json from @adguard/scriptlets by using path remapping feature of Bun, then finds proper uBO resource names.

@seia-soto seia-soto self-assigned this Aug 5, 2024
@seia-soto seia-soto marked this pull request as ready for review August 6, 2024 03:20
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

test/unit/converters/helpers.spec.js Outdated Show resolved Hide resolved
Co-authored-by: chrmod <chrmod@ghostery.com>
@seia-soto seia-soto requested a review from chrmod August 6, 2024 11:05
seia-soto and others added 2 commits August 7, 2024 15:13
Co-authored-by: Philipp Claßen <philipp.classen@posteo.de>
@seia-soto seia-soto merged commit 4067287 into ghostery:main Aug 7, 2024
2 checks passed
seia-soto added a commit to seia-soto/urlfilter2dnr that referenced this pull request Aug 7, 2024
- Handle image files
- Fix path handling
chrmod pushed a commit that referenced this pull request Aug 7, 2024
* feat: remove node dependency

* fix: correct scope

* fix: regressions in #16

- Handle image files
- Fix path handling

* fix: update function to respect nodejs spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants