Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrapping slashes from regexps #20

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove wrapping slashes from regexps #20

merged 1 commit into from
Oct 16, 2024

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented Oct 15, 2024 •
edited
Loading

Wrapping slashes are tolerated by the browsers but fail with additional syntax being used. Ones that we can confirm are ^ and $ for example:

  • /\.com\/[_0-9a-zA-Z]+\.jpg$/

smalluban
smalluban reviewed Oct 16, 2024
View reviewed changes
Copy link

@smalluban smalluban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some more sophisticated tests? Like regexFilters that failed in Safari?

smalluban
smalluban approved these changes Oct 16, 2024
View reviewed changes
Copy link

@smalluban smalluban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More sophisticated cases are covered by other parts of the project.

@chrmod chrmod merged commit 37dbda4 into main Oct 16, 2024
2 checks passed
@chrmod chrmod deleted the remove-regexp-wrapping branch October 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalluban smalluban smalluban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrmod @smalluban