Update terminate to version 2.0.0 🚀 #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
terminate just published its new version 2.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of terminate.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
see: #28
The new version differs by 27 commits .
8179aa8New Version: Removes console.log from output (too noisy!) if you are relying on the console.log, dont upgrade, that is the only thing that has changed see: remove console.log dwyl/terminate#2846d6209Merge pull request #28 from jedwards1211/patch-1f7c3f81remove console.log38a2311Merge pull request #24 from jedwards1211/appveyor-process-kill6e111c6Merge pull request #22 from jedwards1211/handle-pstree-err68637baMerge branch 'master' of github.com:dwyl/terminate into handle-pstree-err80f8545Merge pull request #23 from jedwards1211/appveyor8f0a50eMerge pull request #20 from jedwards1211/process-kill72d1ca9give windows more time to actually kill the processes9f8817cMerge branch 'process-kill' into appveyor-process-kill0fe368cmake sure to kill parent pid too042ade1make sure child processes stay alive for one minute98e1732update ps-tree@1.1.07e68f80Merge branch 'process-kill' into appveyor-process-kill6306866use SIGKILLThere are 27 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade