Apply review comments

Co-authored-by: Tobias Ribizel <ribizel@kit.edu> Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
ginkgo-project · Jul 2, 2024 · 6c0da56 · 6c0da56
1 parent d08eb66
commit 6c0da56
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/reference/matrix/dense_kernels.cpp b/reference/matrix/dense_kernels.cpp
@@ -371,8 +371,6 @@ void compute_mean(std::shared_ptr<const ReferenceExecutor> exec,
                   const matrix::Dense<ValueType>* x,
                   matrix::Dense<ValueType>* result, array<char>&)
 {
-    GKO_ASSERT_EQ(result->get_size()[0], 1);
-
     using ValueType_nc = gko::remove_complex<ValueType>;
     for (size_type j = 0; j < x->get_size()[1]; ++j) {
         result->at(0, j) = zero<ValueType>();

diff --git a/reference/test/matrix/dense_kernels.cpp b/reference/test/matrix/dense_kernels.cpp
@@ -691,14 +691,6 @@ TYPED_TEST(Dense, ComputesMean)
     GKO_EXPECT_NEAR(result->at(0, 2), T{1.0}, r<T>::value * 10);
 }
 
-TYPED_TEST(Dense, ComputesMeanFailsOnZeroRowResults)
-{
-    using Mtx = typename TestFixture::Mtx;
-    using T = typename TestFixture::value_type;
-    auto result = Mtx::create(this->exec, gko::dim<2>{0, 1});
-
-    ASSERT_THROW(this->mtx4->compute_mean(result), gko::ValueMismatch);
-}
 
 TYPED_TEST(Dense, ComputesMeanFailsOnWrongResultSize)
 {