-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ginkgo version in CITATION.cff #1625
Conversation
I always wondered if we should bump the version or not in the citation. My feeling would be not, because the paper doesn't reflect the library content and capacity of version 1.8.0, it maybe does up to 1.3.0 or something like this, in fact. |
Ah I see your point. I thought the first part is meant for a general citation of the library. And additionally we have the prefered paper section which should state the library version indepently. |
Looking at the validation guide, especially the title and prefrerred-citation section, I understand it as the current version of the software and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this and checking how it works.
A last problem for me is the authors list in the citation if this is the software citation. In the best case, it should reflect (or directly come from) the contributors.txt
file, no? Except if we consider main authors only, whatever that means.
Does anyone have any idea how other packages do it?
There is an example of a mixed authors list with persons and anonymous entries.
I guess if we want to distinguish between main named authors and other unnamed authors we could use something like or similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also help me to change my first name?
Co-authored-by: Terry Cojean <terry.cojean@kit.edu> Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
5a77673
to
d300226
Compare
Quality Gate passedIssues Measures |
The version in CITATION.cff is not the most recent, this PR bumps the version to the latest released version 1.8.0.