Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the parent node can have children before getting or adding children #11

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Check if the parent node can have children before getting or adding children #11

merged 2 commits into from
Jul 13, 2023

Conversation

Ausdach
Copy link
Contributor

@Ausdach Ausdach commented Jul 10, 2023

No description provided.

@girishchandranc
Copy link
Owner

girishchandranc commented Jul 10, 2023 •
edited
Loading

Hi @Ausdach ,
Appreciate your contribution. 👍 .

I am happy with the change and the checks wrt unit tests are successful see.
It's ready to be merged.
Would you also mind updating the release notes?, eventhough it's not a big change set.

@Ausdach
Copy link
Contributor Author

Ausdach commented Jul 11, 2023

@girishchandranc Done, Thanks!

@girishchandranc
Copy link
Owner

@Ausdach Thank you. Review successful. Pull request is approved and is ready to be merged. Thanks!

@girishchandranc girishchandranc merged commit 559010e into girishchandranc:main Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ausdach @girishchandranc @ADB9FE