Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests that show Tree control maintains checked/collapsed state #593

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

StanleyGoldman
Copy link
Member

@StanleyGoldman StanleyGoldman commented Feb 26, 2018

  • Adding tests to prove that the load function
    • Loads with collapsed nodes as expected
    • Loads with selected nodes as expected

@StanleyGoldman
Copy link
Member Author

So after my first foray into this, I'm able to reproduce the bug, I see that the load functionality works as expected. I suspect there is a serialization issue, but everything is the same as checked state.

@shana
Copy link
Member

shana commented Apr 9, 2018

There's a bug somewhere, but it's really hard to track down. I got it a couple of times, but it's not consistently reproducible.

collapsed-tree

@StanleyGoldman
Copy link
Member Author

Cool, i changed the labels on the bug.

@StanleyGoldman
Copy link
Member Author

@shana I think after #698 this bug is resolved. See if you can reproduce it.

@StanleyGoldman
Copy link
Member Author

I updated the body of this this pull request.
It does not solve #594 as I've learned that the problem is due to deserialization issues.

@StanleyGoldman StanleyGoldman changed the title Fix to Changes tree to maintain collapsed state Unit tests that show Tree control maintains collapsed state May 10, 2018
@StanleyGoldman
Copy link
Member Author

StanleyGoldman commented Dec 7, 2018

i'm pretty sure it happens every other domain reload

2018-12-07_11-07-47

@StanleyGoldman
Copy link
Member Author

but data that is created after the first domain reload, is persisted after the second domain reload

2018-12-07_10-58-10

@StanleyGoldman
Copy link
Member Author

StanleyGoldman commented Dec 7, 2018

touching the file system twice and focusing unity once, which is one domain reload, as i understand it, also reproduces the issue

2018-12-07_11-07-47

@StanleyGoldman StanleyGoldman changed the title Unit tests that show Tree control maintains collapsed state Unit tests that show Tree control maintains checked/collapsed state Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants