Adding some ways of asking for a password, aka SSH support #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work operations SSH_ASKPASS/GIT_ASKPASS will ask for a password if there isn't one. If the command line asks for a password, use a custom UI to ask for it.
shana
force-pushed
the
enhancements/ssh-support
branch
from
edb884f
to
25e068a
Compare
# Conflicts: # src/GitHub.Api/Application/ApplicationManagerBase.cs
shana
changed the title
|
I had to change my environment variable to make SSH askpass working on windows 10 |
|
Hi what is the status of using ssh for GitHub for Unity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
SSH_ASKPASS/GIT_ASKPASS will ask for a password if there isn't one. If the command
line asks for a password, use a custom UI to ask for it. I haven't tested the custom UI at all because haha I can't get it to trigger, processes that execute with redirected input don't ask for things on the command line. But for windows, at least, SSH_ASKPASS will ask for a password (though it won't cach it apparently).
This also moves reading process output to a thread because if the process asks for input without us noticing, it will hang forever and hang Unity in the process when it wants to kill the domain. This checks if we need to shutdown every second and aborts if needed.