Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding TLS options to freno.
I've looked at the way SSL is initialized in Orchestrator here https://github.com/github/orchestrator/blob/master/go/app/http.go#L149-L161 and tried to follow that example but also do a bit of simplification as well.
I've added a second sample config file in
conf
to enable the tls options for testing so you can invoke freno with:./freno -http -config conf/freno.conf.ssl.json -verbose
That also requires some self-signed certificates to be generated which is straight forward with:
There are a few questions I had about this change.
Also I think this PR isn't complete until it has additional documentation to explain how to configure the server for SSL operation as well.
/cc @shlomi-noach
/cc #112