Add polling-style file watch option #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githubnemo
requested changes
Nov 28, 2020
Co-authored-by: githubnemo <githubnemo@users.noreply.github.com>
|
Thanks a lot! The changes are well implemented and I can see them being useful to workaround the issues around Docker on Mac OS X and Windows bind mounts. |
|
thank you for your thoughtful reviews :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #44 and #47, file watch via
fsnotifyis troublesome in some Mac OS X or Docker environment.So, I implemented optional polling-style file watch mechanism to avoid horrible file system issues as suggested in #44.
It still has optional parameter to choose either polling or fsevent, so non-OS X user won't be affected by this change.