expose remove, remove_and_keep_content and removed? methods on element #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchak
force-pushed
the
add-remove-methods
branch
from
181ca39
to
ba181e0
Compare
|
Nice work! I have a few other changes I keep meaning to merge before the next release—I'll ship this within the week. Thanks! |
|
I looked at the linting errors, and some of them are about code I did not write. Additionally, there are errors related to using patterns that are already present in the existing code without any issues (use of As for the Rust error on Windows, I don't know what's it about. Please let me know if you have any suggestions for fixing these errors or if you would like me to investigate further. |
|
It's all good, I'll take a look at those. |
gjtorikian
force-pushed
the
add-remove-methods
branch
from
a9a3e57
to
91c735d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I am very new to Rust, and even more so to Ruby extensions in Rust. I don't know if I forgot anything, but the tests are passing! 🎉