Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #948

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

updates:
- [github.com/asottile/pyupgrade: v3.8.0 → v3.13.0](asottile/pyupgrade@v3.8.0...v3.13.0)
- [github.com/psf/black: 23.3.0 → 23.9.1](psf/black@23.3.0...23.9.1)
- [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
- [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner October 2, 2023 18:16
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #948 (5eacb62) into main (9d04485) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          20       20           
  Lines        3457     3457           
  Branches      758      758           
=======================================
  Hits         2962     2962           
  Misses        335      335           
  Partials      160      160           
Files Coverage Δ
signac/sync.py 81.43% <100.00%> (ø)
signac/h5store.py 91.03% <0.00%> (ø)

@mikemhenry
Copy link
Collaborator

Looks like we have some things to fix:

signac/h5store.py:260:18: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
signac/sync.py:629:8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
tests/test_h5store.py:216:20: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

@b-butler b-butler requested review from a team as code owners October 3, 2023 15:52
@b-butler b-butler requested review from b-butler and iblanco11981870 and removed request for a team October 3, 2023 15:52
@b-butler b-butler merged commit 4b7ebe1 into main Oct 3, 2023
16 of 17 checks passed
@b-butler b-butler deleted the pre-commit-ci-update-config branch October 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants