Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.2.0 #984

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Release/2.2.0 #984

merged 3 commits into from
Feb 14, 2024

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Feb 13, 2024

Release 2.2.0.

@cbkerr cbkerr requested review from a team as code owners February 13, 2024 20:25
@cbkerr cbkerr requested review from b-butler and jennyfothergill and removed request for a team February 13, 2024 20:25
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d6db63) 86.09% compared to head (5eb9dc8) 86.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   86.09%   86.09%           
=======================================
  Files          20       20           
  Lines        3503     3503           
  Branches      770      770           
=======================================
  Hits         3016     3016           
  Misses        330      330           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaander
Copy link
Member

pre-commit.ci autofix

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

---------------------

Added
+++++

- Official support for Python 3.12 (#957).
- ``Job.cached_statepoint`` - cached and read only access to job state points. Faster than
``Job.statepoint`` (#975).
- ``Job.cached_statepoint`` - cached and read only access to job state points. Faster than ``Job.statepoint`` (#975).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sphinx appears to render your modification correctly: https://signac--984.org.readthedocs.build/projects/core/en/984/changes.html#id1

However, it is technically not valid rst syntax: https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#bullet-lists .

Copy link
Member Author

@cbkerr cbkerr Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix this in a new PR since it's for the whole changelog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it may not be worth the change.

I quite often find lists like this:

- Some entry.
    Continued line.

Or:

1. List item.
    Continue line.

Which rst interprets as definition lists. This does not render as intended in HTML. Apparently, removing all the spaces does. Maybe there is something I missed in the spec about ignoring newlines if the next line does not start with white space?

@cbkerr cbkerr merged commit 44759c5 into main Feb 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants