Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing FXML files with javascript #795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jperedadnr
Copy link
Collaborator

Issue

Fixes #794, by adding flag that enables reading the FXML file with javascript language. Also reverts a small change done in #619, as now the test as it was before passes.

Important note: Scene Builder (workspace/preview) does not evaluate the onAction eventHandlers, so there is no need for a Nashorn engine, and there is no risk of opening any FXML file with any kind of malicious script.

Progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import FXML files with <?language javascript?>
1 participant