Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Info.plist reference (fixes build issue) #106

Closed
wants to merge 1 commit into from
Closed

Update Info.plist reference (fixes build issue) #106

wants to merge 1 commit into from

Conversation

gverdouw
Copy link

@gverdouw gverdouw commented Apr 30, 2019

Updates Info.plist reference to point to actual file

Had to manually edit this as Xcode couldn't find the plist file, gets things building again but I'm not so familiar enough with CocoaPods to know exactly how it got in to this state to begin with. (see #105)

@gverdouw gverdouw changed the title Update Info.plist reference (fixes build issue #105) Update Info.plist reference (fixes build issue) Apr 30, 2019
@gmarm
Copy link
Owner

gmarm commented Apr 30, 2019

Won't running pod install regenerate the Pods project and re-introduce the problem?

@gverdouw
Copy link
Author

Sounds likely, so probably not worth merging unless as a really temporary fix. I’d guess (without research) that this must be a relatively common problem if it happened here, so may be fixed at the cocoapods level already. I’m using this branch for Carthage now so this may be useful to someone else.

@gverdouw
Copy link
Author

gverdouw commented May 1, 2019

So actually I installed Cocoapods and had a play around, I think just running pod update on the Example project fixed the issue.

@gverdouw gverdouw closed this May 1, 2019
@gmarm
Copy link
Owner

gmarm commented May 2, 2019

Does this mean #105 can be closed @gverdouw ?

@gverdouw
Copy link
Author

gverdouw commented May 2, 2019

No, not yet. We will need to delete the Info.plists and add the new ones to the git repo. It works locally, but as the new plists are not in the repo Carthage will fail to build it. I have it working on my fork but in addition to the plists it also made some other changes I don’t quite understand yet

https://github.com/gverdouw/BetterSegmentedControl/commit/b4ff351bc4ff8679bd179c616188136d0f1e005e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants