-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SSH PTY for NOKIA SROS (fix for #86) #107
base: main
Are you sure you want to change the base?
Conversation
Looks good to me. Maybe, for potential other types of router, it would be wise to put this kind of specific code in a dedicated and overridable function. I think that it would be wise and doable, but the |
yes, that was my thought too. But a I'm not so familiar with OOP stuff and currently structure of looking-glass. |
- add new Router::send_telnet_command and Router::send_ssh_command methods so this can be overwritten in Router vendor specific Instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd like to keep the VRF work part out of this PR though. I think it worth creating another PR to introduce the VRF feature since this is a change that can be applied to multiple router types.
Fixes: