-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme with information about Docker container #242
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,14 +57,10 @@ https://godoc.org/github.com/go-debos/debos/actions | |
|
||
## Installation (Docker container) | ||
|
||
Official debos container is available: | ||
``` | ||
docker pull godebos/debos | ||
``` | ||
A Docker container containing the latest version of Debos is available from [Docker Hub](https://hub.docker.com/r/godebos/debos). | ||
See [docker/README.md](https://github.com/go-debos/debos/blob/master/docker/README.md) for more information and usage. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also the links in this file need to be modified |
||
|
||
See [docker/README.md](https://github.com/go-debos/debos/blob/master/docker/README.md) for usage. | ||
|
||
## Installation (under Debian) | ||
## Installation from source (under Debian) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a section about installing from packages in debian |
||
|
||
sudo apt install golang git libglib2.0-dev libostree-dev qemu-system-x86 \ | ||
qemu-user-static debootstrap systemd-container | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ docker pull godebos/debos | |
``` | ||
|
||
Debos needs virtualization to be enabled on the host and shared with the container. | ||
|
||
Check that `kvm` is enabled and writable by the user running the docker container by running ```ls /dev/kvm``` | ||
|
||
## Usage | ||
|
@@ -17,7 +16,14 @@ Check that `kvm` is enabled and writable by the user running the docker containe | |
To build `recipe.yaml`: | ||
``` | ||
cd <PATH_TO_RECIPE_DIR> | ||
docker run --rm --interactive --tty --device /dev/kvm --user $(id -u) --workdir /recipes --mount "type=bind,source=$(pwd),destination=/recipes" --security-opt label=disable godebos/debos <RECIPE.yaml> | ||
docker run --rm --interactive --tty \ | ||
--device /dev/kvm \ | ||
--user $(id -u):$(id -g) \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's typically not needed |
||
--group-add $(getent group kvm | cut -d: -f3) \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kvm has uaccess tagged on modern systems so this is also not needed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. right, just having a look at this again since i don't fully understand the permissions here.
debos with kvm backend runs when i run it locally outside of docker, but not inside a container it breaks without this hunk of the patch:
i am probably doing something wrong here, or my system is configured incorrectly! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hm seems like if i remove the |
||
--workdir /recipes \ | ||
--mount "type=bind,source=$(pwd),destination=/recipes" \ | ||
--security-opt label=disable \ | ||
godebos/debos recipe.yaml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use ghcr |
||
``` | ||
|
||
## Container build | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should point to ghcr first