Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/image-partition: check if the filesystem is mountable #268

Merged

Conversation

vigneshraman
Copy link
Contributor

@vigneshraman vigneshraman commented Jul 22, 2021

If the filesystem type is 'none', it results in the below error.
==== image-partition ====
Action image-partition failed at stage Run, error: root mount failed: no such device
Warning: Failed to get unmount /boot/efi: no such file or directory
Unmount failure can cause images being incomplete!
Powering off.

Report an error message if filesystem type is 'none' and exit.

Fixes: #234

Signed-off-by: Vignesh Raman vignesh.raman@collabora.com

@vigneshraman vigneshraman force-pushed the vigneshraman/debos/issues/234 branch from bc180e4 to c16c53e Compare July 23, 2021 10:05
actions/image_partition_action.go Outdated Show resolved Hide resolved
@vigneshraman vigneshraman force-pushed the vigneshraman/debos/issues/234 branch from c16c53e to c113a66 Compare July 26, 2021 05:21
@vigneshraman vigneshraman changed the title actions/image-partition: mount a partition only with a valid filesystem actions/image-partition: check if the filesystem is mountable Jul 26, 2021
actions/image_partition_action.go Outdated Show resolved Hide resolved
@vigneshraman vigneshraman force-pushed the vigneshraman/debos/issues/234 branch 3 times, most recently from b5f9609 to 9cfb0a9 Compare July 27, 2021 09:58
actions/image_partition_action.go Outdated Show resolved Hide resolved
If the filesystem type is 'none', it results in the below error.
==== image-partition ====
Action `image-partition` failed at stage Run, error: root mount failed: no such device
Warning: Failed to get unmount /boot/efi: no such file or directory
Unmount failure can cause images being incomplete!
Powering off.

Report an error message if filesystem type is 'none' and exit.

Fixes: go-debos#234

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
@obbardc obbardc force-pushed the vigneshraman/debos/issues/234 branch from b00ef7f to a31e79e Compare July 17, 2023 08:38
@sjoerdsimons sjoerdsimons added this pull request to the merge queue Dec 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2023
@sjoerdsimons sjoerdsimons added this pull request to the merge queue Dec 31, 2023
Merged via the queue into go-debos:main with commit b214c9a Dec 31, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

actions: image-partition: should only attempt to mount a partition with a filesystem
3 participants