Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metricstorage): add schema for metrics #181

Merged
merged 54 commits into from
Nov 12, 2023
Merged

feat(metricstorage): add schema for metrics #181

merged 54 commits into from
Nov 12, 2023

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Oct 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1613 lines in your changes are missing coverage. Please review.

Comparison is base (388864d) 53.33% compared to head (b5bb3ed) 47.17%.

❗ Current head b5bb3ed differs from pull request most recent head d289d55. Consider uploading reports for the commit d289d55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   53.33%   47.17%   -6.16%     
==========================================
  Files         147      161      +14     
  Lines       11220    12966    +1746     
==========================================
+ Hits         5984     6117     +133     
- Misses       4990     6601    +1611     
- Partials      246      248       +2     
Files Coverage Δ
internal/metricsharding/time_map.go 100.00% <100.00%> (ø)
internal/promhandler/options.go 0.00% <0.00%> (ø)
internal/metricsharding/block.go 65.62% <65.62%> (ø)
internal/promhandler/error.go 0.00% <0.00%> (ø)
internal/promhandler/params.go 68.65% <68.65%> (ø)
internal/metricstorage/schema.go 0.00% <0.00%> (ø)
internal/otelstorage/hash.go 15.58% <15.58%> (ø)
internal/metricsharding/metricsharding.go 0.00% <0.00%> (ø)
internal/promhandler/promql.go 0.00% <0.00%> (ø)
internal/metricsharding/sharder.go 15.75% <15.75%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota force-pushed the feat/metrics branch 5 times, most recently from 25ba41a to 9984409 Compare October 5, 2023 14:53
@tdakkota tdakkota force-pushed the feat/metrics branch 4 times, most recently from dc56195 to f059e67 Compare November 2, 2023 13:40
@ernado ernado marked this pull request as ready for review November 12, 2023 10:07
@ernado
Copy link
Member

ernado commented Nov 12, 2023

Moving development to main branch.

@ernado ernado merged commit bc9b85a into main Nov 12, 2023
3 of 12 checks passed
@ernado ernado deleted the feat/metrics branch November 12, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants