Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chstorage): implement metrics storage #229

Merged
merged 112 commits into from
Dec 1, 2023
Merged

Conversation

tdakkota
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4022 lines in your changes are missing coverage. Please review.

Comparison is base (d974f5b) 47.36% compared to head (49d026d) 39.42%.
Report is 10 commits behind head on main.

❗ Current head 49d026d differs from pull request most recent head c234ffa. Consider uploading reports for the commit c234ffa to get more accurate results

Files Patch % Lines
internal/otelschema/group.go 20.49% 1418 Missing and 83 partials ⚠️
internal/chstorage/querier_metrics.go 0.00% 516 Missing ⚠️
internal/chstorage/querier_traces.go 0.00% 364 Missing ⚠️
internal/chstorage/inserter_metrics.go 0.00% 249 Missing ⚠️
internal/chstorage/columns_traces.go 0.00% 227 Missing ⚠️
internal/chstorage/querier_logs.go 0.00% 188 Missing ⚠️
internal/chstorage/columns_metrics.go 0.00% 176 Missing ⚠️
internal/chstorage/querier_metrics_hist.go 0.00% 136 Missing ⚠️
internal/chstorage/columns_logs.go 0.00% 123 Missing ⚠️
integration/prome2e/prom_e2e.go 0.00% 109 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   47.36%   39.42%   -7.95%     
==========================================
  Files         161      180      +19     
  Lines       12978    16722    +3744     
==========================================
+ Hits         6147     6592     +445     
- Misses       6583     9800    +3217     
- Partials      248      330      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota force-pushed the feat/metrics-chstorage branch 2 times, most recently from 6f54650 to 9f3903d Compare November 21, 2023 11:45
@ernado ernado force-pushed the feat/metrics-chstorage branch from 640f44f to 4c9a5bd Compare November 29, 2023 17:31
@ernado ernado marked this pull request as ready for review December 1, 2023 09:57
@ernado ernado force-pushed the feat/metrics-chstorage branch from c234ffa to 9948616 Compare December 1, 2023 09:57
@ernado ernado merged commit 19497e3 into main Dec 1, 2023
@ernado ernado deleted the feat/metrics-chstorage branch December 1, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants