Add support for OF in row lock clauses #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 90.62% 90.63% +0.01%
==========================================
Files 124 124
Lines 7079 7094 +15
==========================================
+ Hits 6415 6430 +15
Misses 513 513
Partials 151 151 ☔ View full report in Codecov by Sentry. |
go-jet
reviewed
Nov 22, 2023
|
Could you also add one integration test just to make sure everything works with live db. |
Done in 71654cd. |
go-jet
reviewed
Nov 28, 2023
go-jet
reviewed
Nov 28, 2023
go-jet
reviewed
Nov 28, 2023
This adds support for statements such as `SELECT ... FOR UPDATE OF table NOWAIT` where `OF table` could not be specified previously. Fixes #285.
mattdowdell
changed the title
|
LGTM. 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for statements such as
SELECT ... FOR UPDATE OF table NOWAITwhereOF tablecould not be specified previously. Fixes #285.