Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 204 no content handling #654

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Improve 204 no content handling #654

merged 2 commits into from
Sep 17, 2023

Conversation

haivp3010
Copy link
Contributor

@haivp3010 haivp3010 commented May 5, 2023

fixes #652
fixes #653
fixes #678

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haivp3010 Thanks for your PR, appreciated.

Please see the requested changes, also added possible test cases.

response.go Show resolved Hide resolved
response.go Show resolved Hide resolved
@jeevatkm jeevatkm added this to the v2.8.0 Milestone milestone Sep 17, 2023
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (15cedd4) 95.73% compared to head (8aec1bb) 95.62%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   95.73%   95.62%   -0.11%     
==========================================
  Files          11       11              
  Lines        1571     1601      +30     
==========================================
+ Hits         1504     1531      +27     
- Misses         41       42       +1     
- Partials       26       28       +2     
Files Changed Coverage Δ
middleware.go 92.09% <100.00%> (+1.41%) ⬆️
response.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 6ea5279 into go-resty:master Sep 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment