Add environment variable handling to Google Pay #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikolas4175-godaddy I cherry-picked the FW version number changes to the release/5.11.7 branch, so that we can PR other fixes and changes to the release. I've also adjusted the base branch here so your PR gets merged into the release branch first. |
* load payment form assets for gateways that support adding payment methods also * use flexbox for aligning payment gateway icons * extract selector styles to method * Ensure FW gateways with no CC icons still align to the right * Add since version to newly added method * Update changelog --------- Co-authored-by: Fulvio Notarstefano <fulvio.notarstefano@gmail.com>
|
@nikolas4175-godaddy @ragulka this branch has been rebased to use #611 (5.11.8 release branch) since we have tagged v5.11.7 |
|
Discussed in Slack (thread), but for clarity: It seems that more changes are needed at the plugin (and possibly also FW) level to get Google Pay txns working in Prod (AC2 above), but the change in this PR is certainly a part of that and meets AC1 so I'll move this out of draft to prevent further blockers or rebasing work while we sort this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds handling for passing the appropriate Environment variable (i.e.
PRODUCTIONorTEST) when setting up the Google Pay JS client for gateways that implement the Google Pay Frontend class. Previously no environment variable was passed, which will cause txns to default to TEST according to the Google Pay docs.Closes #566
Story: MWC-3539
Acceptance Criteria