Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in debug, include location information in error message on panic #926

Merged
merged 3 commits into from
Nov 5, 2024
Merged

in debug, include location information in error message on panic #926

merged 3 commits into from
Nov 5, 2024

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Oct 22, 2024

fixes #923

image

@Bromeon Bromeon added bug c: core Core components labels Oct 22, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-926

@0x53A
Copy link
Contributor Author

0x53A commented Oct 23, 2024 •
edited
Loading

(I ran cargo fmt --all and rebased/force pushed)

@Bromeon
Copy link
Member

Bromeon commented Nov 5, 2024

Thanks a lot!

Rebased onto master, and added a small trick to avoid tedious maintenance when the line number changes (which is very likely in that file). Also didn't want to create just another class in another file.

@Bromeon Bromeon added this pull request to the merge queue Nov 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
@Bromeon
Merge pull request #926 from 0x53A/dev
411dfde 
in debug, include location information in error message on panic
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@Bromeon Bromeon added this pull request to the merge queue Nov 5, 2024
Merged via the queue into godot-rust:master with commit 3722014 Nov 5, 2024
15 checks passed
@0x53A 0x53A deleted the dev branch November 7, 2024 02:22
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals and removed bug labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: core Core components quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On panic in a godot-rust call, location information is thrown away and not shown
3 participants
@0x53A @GodotRust @Bromeon