-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BasicAuthMiddleware #996
Comments
@aryanmehrotra Please assign this issue to me |
Hi @aryanmehrotra |
@kuldeep-bishnoi - This is already assigned to @iamshubha, so can't assign this to you as of now.. if Shubha doesn't pick this up then maybe you can work on this. |
@iamshubha Are you working on this, Please raise a PR or we would have to unassign this issue. |
@iamshubha unassigning the issue to you because of unactiveness and no reply. @kuldeep-bishnoi would you like to work on it ? |
@Umang01-hash I've refactored the BasicAuthMiddleware function to reduce its cognitive complexity. When you have a moment, could you please review the changes? I’d appreciate any feedback on the refactor or suggestions for further improvement. |
Sure @nidhey27 we will review it and let you know about any changes if needed. |
@Umang01-hash do you guys have slack channel or anything for communication with maintainer? |
Function BasicAuthMiddleware has a Cognitive Complexity of 19 (exceeds 12 allowed).
Refer : https://codeclimate.com/github/gofr-dev/gofr/issues?category=complexity&engine_name%5B%5D=structure&engine_name%5B%5D=duplication
The text was updated successfully, but these errors were encountered: