Issue - 996 | Refactor BasicAuthMiddleware to reduce cognitive complexity #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nidhey27 <nidhey60@gmail.com>
nidhey27
force-pushed
the
refactor/basic-auth-middleware
branch
from
03ec4c9
to
b2d176c
Compare
|
@nidhey27 your PR has some failing tests as well as code quality issues. Please resolve them |
|
@Umang01-hash sure I will have a look at it. Also a bit busy today with my day job so I will try to close this by coming weekend. |
Signed-off-by: nidhey27 <nidhey60@gmail.com>
nidhey27
force-pushed
the
refactor/basic-auth-middleware
branch
from
ffe2bcd
to
7637fdf
Compare
vipul-rawat
reviewed
Nov 16, 2024
| middleware(handler).ServeHTTP(rr, req) | ||
|
|
||
| assert.Equal(t, http.StatusUnauthorized, rr.Code) | ||
| assert.Contains(t, rr.Body.String(), "Unauthorized: Authorization header missing") |
There was a problem hiding this comment.
This test condition is failing as, on missing header the checks respond with - "Invalid or missing header"
use global map of channels to recieve messages to avoid recieving on a closed channel
|
@Umang01-hash @vipul-rawat Were the recent changes you made intentional or accidental? |
|
@nidhey27 We haven't committed anything intentionally. I think you pulled from development and all our recent commits there got merged. |
vikash
reviewed
Nov 24, 2024
|
|
||
| // respondUnauthorized sends a 401 Unauthorized response with a given message. | ||
| func respondUnauthorized(w http.ResponseWriter, message string) { | ||
| http.Error(w, "Unauthorized: "+message, http.StatusUnauthorized) |
There was a problem hiding this comment.
function with single line in its body may not be required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes: #996
Description:
parseBasicAuthto handle authorization header parsingrespondUnauthorizedfor consistent unauthorized responsesvalidateCredentialsChecklist:
goimportandgolangci-lint.