-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correcting time unit for logs of added http-service #1214
base: development
Are you sure you want to change the base?
Fix: Correcting time unit for logs of added http-service #1214
Conversation
Please update the PR description -we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds. |
@ccoVeille , I mean what I wrote. The log displays 8 microseconds where in actually gofr calculates it as 8 milliseconds. So we are correcting that, to corrrectly show ....8,000 µs. |
OK, so I think I'm lost. Let's reboot. Your text says:
So it means
The code :
So for me, there is a problem with the text. The code is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changes for transaction in SQL DB and openTSDB
Pull Request Template
Description:
Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!