linux: send the correct for TARGETS request #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the X11 implementation, the code always send text and
image/pngforTARGETSrequest. This means that rich-content applications (like Chromium) would always try to request all the available content types (since the Web does allow querying different types of clipboard content) and this causes Chromium and Electron to hang.This also confuses clipboard managers, which tries to check if they can support saving and taking over clipboard content based on
TARGETS. In particular, this makes KDE Plasma 6's clipboard manager NOT recognize anything copied with this package.This PR makes it send the correct pair of targets (
TARGETS, text orimage/png) for SelectionRequest.This fixes hang/crash when pasting into Chromium and Electron-based apps, and the clipboard content shows up in KDE Plasma's clipboard manager.