-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/gerritbot: leave a CL comment on a freshly imported PR to help confirm the author has a Gerrit account #69
base: master
Are you sure you want to change the base?
Conversation
…nfirm author has a Gerrit account
This PR (HEAD: 6d27e14) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/build/+/509135 to see it. Tip: You can toggle comments from me using the |
Message from Heschi Kreinick: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
This PR (HEAD: 6d27e14) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/build/+/509135. Important tips:
|
Message from t hepudds: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
Message from Heschi Kreinick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
Message from Heschi Kreinick: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
Message from t hepudds: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
Message from Heschi Kreinick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/509135. |
WIP. Quick & dirty draft for discussion purposes. (Builds, but otherwise
untested).
In discussion golang/go#61182, Bryan's list of friction around the
GitHub PR workflow includes:
"A significant fraction of GitHub PRs are abandoned when the author
does not respond to Gerrit comments, but the existence of an open
PR discourages other contributors from working on the corresponding
issue."
We attempt to partially mitigate that by adding an unresolved welcome
comment to Gerrit to provide some context to the PR author but also
to help a reviewer see if/when the author has registered for a Gerrit
account.
In the future, we could possibly also have a reminder or even
abandon the CL if the author never replies, but for now, those are
left as possible TODOs in the code.
Fixes golang/go#61316