Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure MIMEHeader is always initialized #70143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/net/textproto/header_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

package textproto

import "testing"
import (
"testing"
)

type canonicalHeaderKeyTest struct {
in, out string
Expand Down Expand Up @@ -33,6 +35,17 @@ var canonicalHeaderKeyTests = []canonicalHeaderKeyTest{
{"foo bar", "foo bar"},
}

func TestNilMapSetOrAdd(t *testing.T) {
defer func() {
if r := recover(); r != nil {
t.Errorf("nil MIMEHeader caused panic: %v", r)
}
}()
var h MIMEHeader
h.Set("foo", "bar")
h.Add("biz", "boo")
}

func TestCanonicalMIMEHeaderKey(t *testing.T) {
for _, tt := range canonicalHeaderKeyTests {
if s := CanonicalMIMEHeaderKey(tt.in); s != tt.out {
Expand Down