-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/godoc: add versioning for links to std packages #94
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: a1cd5a3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/606395. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606395. |
Message from Alex Bozhenko: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606395. |
Message from Alex Bozhenko: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606395. |
Message from Alex Bozhenko: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606395. |
This PR (HEAD: ad9dafc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/606395. Important tips:
|
This PR (HEAD: 9236b0f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/606395. Important tips:
|
Message from Alex Bozhenko: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/606395. |
It turns out that not including versions in the links to
standard library packages can be problematic.
For example, Go 1.23.0 added the iter package and the maps.Keys function.
https://pkg.go.dev/iter@go1.23rc2#hdr-Standard_Library_Usage
This paragraph contains a link to https://pkg.go.dev/maps#Keys,
and that link was broken before version 1.23.0 was released.
With this change, versions will always be included in the links
to standard library packages, even when browsing the latest version.
Fixes golang/go#68755