-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_content/doc: use mysql.NewConfig() instead of mysql.Config{} #281
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 99bbecf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
This tutorial confuses users. |
Message from Inada Naoki: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
Message from Zhen Li: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
This PR (HEAD: 1031334) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/582475. Important tips:
|
Message from Inada Naoki: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/582475. |
The zero values for
mysql.Config
is not good for default.See https://pkg.go.dev/github.com/go-sql-driver/mysql#Config