Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Python importlib_metadata requirements when building Dockerfile.base #1294

Conversation

giogix2
Copy link
Contributor

@giogix2 giogix2 commented Dec 2, 2024

This PR fixes the following issue #1293.
In particular, when building the docker, the following error is thrown
AttributeError: module 'importlib_metadata' has no attribute 'EntryPoints'
This solution was suggested in this this Stackoverflow post.

@lanctot
Copy link
Collaborator

lanctot commented Dec 4, 2024

Thank you!

@lanctot
Copy link
Collaborator

lanctot commented Dec 5, 2024

Same here please: Can you pull changes from master and push the merge commit to trigger the CI tests again?

@giogix2
Copy link
Contributor Author

giogix2 commented Dec 6, 2024

Let me know if this one is failing because of my change. I guess it's not the case, as from what I understand this Dockerfile is not tested in the CI/CD. I was wondering whether it's still the same issue as lat time, but the other to PRs have worked after the latest changes 🤔.

@lanctot
Copy link
Collaborator

lanctot commented Dec 6, 2024

Oh, that file_test periodically fails.. I'm never sure why, it's non-deterministic (maybe a race condition).

So yes, certainly not due to your PR. I've restarted the CI tests. Maybe I can file an issue to remind us to fix it.

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Dec 9, 2024
@lanctot lanctot merged commit 7744a2c into google-deepmind:master Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants