Add "Skip Device Validation" checkbox to capture dialog

google · Nov 26, 2024 · d1e74d4 · d1e74d4
1 parent 990afe0
commit d1e74d4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/gapic/src/main/com/google/gapid/util/Flags.java b/gapic/src/main/com/google/gapid/util/Flags.java
@@ -222,7 +222,7 @@ public boolean isSpecified() {
       return specified;
     }
 
-    void setValue(String value) {
+    public void setValue(String value) {
       this.value = parser.parse(value);
       this.specified = true;
     }

diff --git a/gapic/src/main/com/google/gapid/views/TracerDialog.java b/gapic/src/main/com/google/gapid/views/TracerDialog.java
@@ -343,6 +343,7 @@ private static class TraceInput extends Composite {
       private final Label startUnit;
       private final Button useAndroidFrameBoundaryExtension;
       private final Button withoutBuffering;
+      private final Button skipDeviceValidation;
       private final Button includeUnsupportedExtensions;
       private final Button loadValidationLayer;
       private final Button clearCache;
@@ -425,7 +426,22 @@ public TraceInput(Composite parent, TraceType type, Models models, Widgets widge
           logFailure(LOG, Scheduler.EXECUTOR.schedule(refreshDevices, 300, TimeUnit.MILLISECONDS));
         });
 
-        // Align label with first line of text.
+        Label skipDeviceValidationLabel = createLabel(mainGroup, "");
+        Composite skipDeviceValidationComposite = withLayoutData(createComposite(mainGroup,
+            withMarginOnly(new GridLayout(2, false), 0, 0)),
+            new GridData(SWT.FILL, SWT.FILL, true, false));
+
+        skipDeviceValidation = withLayoutData(createCheckbox(skipDeviceValidationComposite, "Skip Device Validation", Devices.skipDeviceValidation.get()), new GridData(SWT.END, SWT.FILL, false, false));
+        skipDeviceValidation.addListener(SWT.Selection, e -> {
+          if(skipDeviceValidation.getSelection()) {
+            Devices.skipDeviceValidation.setValue("true");
+          } else {
+            Devices.skipDeviceValidation.setValue("false");
+          }
+          logFailure(LOG, Scheduler.EXECUTOR.schedule(refreshDevices, 300, TimeUnit.MILLISECONDS));
+        });
+
+          // Align label with first line of text.
         withLayoutData(createLabel(mainGroup, "Validation:"),
           withIndents(new GridData(GridData.HORIZONTAL_ALIGN_FILL | GridData.VERTICAL_ALIGN_BEGINNING), 0, 12));
         deviceValidationView = new DeviceValidationView(mainGroup, this.models, widgets);